Open
Conversation
Member
|
Thanks for this PR Chillar. I hope you've had a good Christmas break :) I'd say that rather than returning a set of the emoticons, we should return a dictionary with the count of how many times the emoticon is used. So it may return, for example: This would allow us to take into account over-use of smileys etc, but also mean we could get the same set of emoticons using I'm planning on doing some more Nidaba over the next few days. |
Member
|
We also need much more thorough unittests. Add more if you can, but if you can't think of any more thorough ones then just PR it and I'll add a few more before merging. |
Contributor
Author
|
get_emoticons accepts string or list of words. modified unit tests. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
used
split()instead of regex to extract emoticons.